docs: Improve the doc about BrowserWindow title property #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
requested changes
Dec 17, 2018
There was a problem hiding this comment.
Overall looks good to me, just a minor grammatical correction is needed.
Also, next time please follow the Pull Request template, leaving in the Checklist and Release Notes section, eg:
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] PR description included and stakeholders cc'd
- [x] `npm test` passes
- [x] relevant documentation is changed or added
- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)
#### Release Notes
<!-- Used to describe release notes for future release versions. Use `no-notes` to indicate no user-facing changes. -->
Notes: Updated description of BrowserWindow title property.
jkleinsc
changed the title
Co-Authored-By: popod <popod@me.com>
|
@jkleinsc thanks for the review and sorry for the PR template. |
jkleinsc
approved these changes
Dec 17, 2018
codebytere
approved these changes
Dec 17, 2018
|
No Release Notes |
|
Hey @codebytere and @jkleinsc, next time please review the release notes as well as the change. I've edited Clerk's comment above for now, but please help us not end up with a big mess of notes to sort through in 5.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Only a simple doc improvement about
BrowserWindowtitlepropertyChecklist
npm testpassesRelease Notes
Notes: Updated description of BrowserWindow title property.