Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mac support to systemPrefs.getColor() #16249

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

commented Jan 3, 2019

Description of Change

Resolves #16246. Adds MacOS support to systemPreferences.getColor().

TODO

  • documentation updates
  • @available wrapping around newer apis

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app-developers

Release Notes

Notes: Added macOS support to systemPreferences.getColor().

@codebytere codebytere requested a review from as a code owner Jan 3, 2019

@codebytere codebytere requested a review from as a code owner Jan 3, 2019

@codebytere codebytere changed the title [wip] feat: add mac support to systemPrefs.getColor() feat: add mac support to systemPrefs.getColor() Jan 3, 2019

@codebytere codebytere force-pushed the add-mac-color-support branch 2 times, most recently from b9de800 to dcc47c3 Jan 3, 2019

@BinaryMuse
Copy link
Member

left a comment

One minor docs change otherwise 📝

Show resolved Hide resolved docs/api/system-preferences.md
@miniak

miniak approved these changes Jan 3, 2019

@codebytere codebytere force-pushed the add-mac-color-support branch 2 times, most recently from 552c7be to 4d1738e Jan 3, 2019

@codebytere codebytere force-pushed the add-mac-color-support branch from d76f9cb to fb6bc73 Jan 3, 2019

@codebytere codebytere merged commit b57046e into master Jan 4, 2019

25 of 27 checks passed

electron-arm-testing Build #20190103.35 has failed
Details
Artifact Comparison Changes Detected
Details
Absolute Zero
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
electron-arm64-testing Build #20190103.35 succeeded
Details
electron-lint Build #20190103.49 succeeded
Details
electron-mas-testing Build #20190103.59 succeeded
Details
electron-osx-testing Build #20190103.59 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Jan 4, 2019

Release Notes Persisted

Added macOS support to systemPreferences.getColor().

@codebytere codebytere deleted the add-mac-color-support branch Jan 4, 2019

andrewkisliakov-citrix added a commit to andrewkisliakov-citrix/electron that referenced this pull request Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.