Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: security: improve IPC validation in guest-view-manager #16252

Merged
merged 1 commit into from
Jan 5, 2019
Merged

fix: security: improve IPC validation in guest-view-manager #16252

merged 1 commit into from
Jan 5, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jan 3, 2019 •
edited

Description of Change

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak added the wip ⚒ label Jan 3, 2019
@miniak miniak requested a review from a team January 3, 2019 18:32
@miniak miniak self-assigned this Jan 3, 2019
@miniak miniak changed the title [wip] security: improve IPC validation in guest-view-manager security: improve IPC validation in guest-view-manager Jan 3, 2019
@miniak miniak removed the wip ⚒ label Jan 3, 2019
@miniak miniak mentioned this pull request Jan 3, 2019
Merged
6 tasks
@miniak
Copy link
Contributor Author

miniak commented Jan 3, 2019

@zcbenz can you please review?

ppontes
ppontes approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@ppontes ppontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nornagon
nornagon approved these changes Jan 4, 2019
View reviewed changes
lib/browser/guest-view-manager.js Outdated Show resolved Hide resolved
@miniak miniak changed the title security: improve IPC validation in guest-view-manager fix: security: improve IPC validation in guest-view-manager Jan 5, 2019
@nornagon nornagon merged commit 959c7a7 into master Jan 5, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 5, 2019

No Release Notes

@nornagon nornagon deleted the miniak/guest-view-manager branch January 5, 2019 00:47
@trop trop bot mentioned this pull request Jan 5, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jan 5, 2019

I have automatically backported this PR to "4-0-x", please check out #16283

@trop trop bot added the merged/4-0-x label Jan 12, 2019
@miniak miniak mentioned this pull request Jul 2, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

@ppontes ppontes ppontes approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@felixrieseberg felixrieseberg Awaiting requested review from felixrieseberg

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @nornagon @codebytere @ppontes