Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: promise_util promise creation #16401

Merged
merged 5 commits into from
Jan 15, 2019
Merged

refactor: promise_util promise creation #16401

merged 5 commits into from
Jan 15, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 15, 2019 •
edited

Description of Change

Move code to enter the js env inside the promise helper, and refactor other code accordingly. Fixes an issue with getFileIcon() crashing locally.

/cc @zcbenz @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team January 15, 2019 05:51
@codebytere codebytere changed the title refactor: promise_util creation refactor: promise_util promise creation Jan 15, 2019
@codebytere codebytere requested a review from ckerr January 15, 2019 16:51
ckerr
ckerr approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work. 👍

@codebytere codebytere merged commit 8e2ab8b into master Jan 15, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 15, 2019

No Release Notes

@codebytere codebytere deleted the promise-refactor branch January 17, 2019 00:10
akisctx pushed a commit to akisctx/electron that referenced this pull request Jan 22, 2019
@codebytere @akisctx
refactor: promise_util promise creation (electron#16401)
7c81fe7 
* refactor: promise_util creation

* enter correct contexts on resolve/reject

* return Local in helper

* set context correctly

* forgot one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @ckerr