feat: promisify webContents.hasServiceWorker() #16535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
promisify-hasserviceworker
branch
3 times, most recently
from
a101706
to
f25b37d
Compare
ckerr
approved these changes
Jan 25, 2019
codebytere
force-pushed
the
promisify-hasserviceworker
branch
from
38d152e
to
767c1bc
Compare
codebytere
changed the title
codebytere
changed the title
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Promifisify
contents.hasServiceWorker().cc @ckerr @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Converted
webContents.hasServiceWorker()to return a promise instead of taking a callback.