fix: improve the way frameless windows are handled on Windows #16596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #15816.
Most of the ideas implemented here come from this post, which is mentioned in several comments. Particularly the idea to use insets on the
RootView
comes from this part:I also took inspiration from this repo, but decided to not mess with undocumented events.
I tested these changes when I put this PR together on Windows 10, 8.1, and 7.
Checklist
npm test
passesRelease Notes
Notes:
Improved the way frameless windows are handled on Windows.