Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show proper clerk notes in release notes script (backport: 4-0-x) #16678

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 1, 2019

Backport of #16659

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from a team February 1, 2019 16:31
@trop trop bot added 4-2-x backport This is a backport PR labels Feb 1, 2019
@codebytere codebytere merged commit 3f68d69 into electron:4-0-x Feb 2, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 2, 2019

No Release Notes

codebytere added a commit that referenced this pull request Feb 2, 2019
codebytere pushed a commit that referenced this pull request Feb 2, 2019
#16678)

* fix: Note detection in PR

* fix: 'BREAKING CHANGE' detection in PR body

* fix: when to include PRs that landed in other branches too

* fix: when available, use clerk's notes
codebytere added a commit that referenced this pull request Feb 4, 2019
* fix: show proper clerk notes in release notes script (backport: 4-0-x) (#16678)

* fix: Note detection in PR

* fix: 'BREAKING CHANGE' detection in PR body

* fix: when to include PRs that landed in other branches too

* fix: when available, use clerk's notes

* address throw edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants