Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carry through arguments in webContents.print() (backport: 5-0-x) #17117

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Feb 25, 2019

Backport of #17052

See that PR for details.

Notes: Fix webContents.print() not working correctly

@trop trop bot requested a review from as a code owner Feb 25, 2019

@trop trop bot referenced this pull request Feb 25, 2019

Merged

fix: carry through arguments in webContents.print() #17052

4 of 4 tasks complete

@trop trop bot added 5-0-x backport labels Feb 25, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Feb 26, 2019

@codebytere codebytere merged commit 8cf0e8e into electron:5-0-x Feb 27, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 27, 2019

Release Notes Persisted

Fix webContents.print() not working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.