Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify session.clearStorageData() #17249

Merged
merged 1 commit into from
Mar 8, 2019
Merged

feat: promisify session.clearStorageData() #17249

merged 1 commit into from
Mar 8, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 6, 2019 •
edited
Loading

Description of Change

This PR promisifies session.clearStorageData(). I removed the synchronous version, since i think it's not altogether necessary and simplifies the overall changes that need to be made.

Checklist

Release Notes

Notes: Converted session.clearStorageData() such that it returns a Promise instead of taking a callback.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 6, 2019
@codebytere codebytere changed the title feat: promisify session.clearStorageData feat: promisify session.clearStorageData() Mar 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2019
@codebytere codebytere force-pushed the promisify-clearstoragedata branch 2 times, most recently from 0bfa9bb to 1088c4e Compare March 8, 2019 04:55
@codebytere codebytere added the semver/major incompatible API changes label Mar 8, 2019
deepak1556
deepak1556 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with style change.

atom/browser/api/atom_api_session.cc Show resolved Hide resolved
@codebytere codebytere merged commit bbfa63f into master Mar 8, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2019

Release Notes Persisted

Converted session.clearStorageData() such that it returns a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-clearstoragedata branch March 8, 2019 17:03
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify session.clearStorageData() (electron#17249)
db1a7e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @deepak1556 @miniak