Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify session.clearStorageData() #17249

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 6, 2019

Description of Change

This PR promisifies session.clearStorageData(). I removed the synchronous version, since i think it's not altogether necessary and simplifies the overall changes that need to be made.

Checklist

Release Notes

Notes: Converted session.clearStorageData() such that it returns a Promise instead of taking a callback.

@codebytere codebytere requested review from deepak1556, miniak and zcbenz Mar 6, 2019

@codebytere codebytere changed the title feat: promisify session.clearStorageData feat: promisify session.clearStorageData() Mar 7, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 7, 2019

@codebytere codebytere force-pushed the promisify-clearstoragedata branch 2 times, most recently from 0bfa9bb to 1088c4e Mar 8, 2019

@deepak1556
Copy link
Member

left a comment

LGTM, with style change.

Show resolved Hide resolved atom/browser/api/atom_api_session.cc

@codebytere codebytere force-pushed the promisify-clearstoragedata branch from 1088c4e to 375a867 Mar 8, 2019

@miniak

miniak approved these changes Mar 8, 2019

@codebytere codebytere merged commit bbfa63f into master Mar 8, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190308.30 succeeded
Details
electron-arm64-testing Build #20190308.31 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 8, 2019

Release Notes Persisted

Converted session.clearStorageData() such that it returns a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-clearstoragedata branch Mar 8, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.