Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the result when calling js function (backport: 5-0-x) #17481

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Mar 20, 2019

Backport of #17443

See that PR for details.

Notes: Fix crash when passing callbacks which return undefined to some APIs.

@trop trop bot referenced this pull request Mar 20, 2019

Merged

fix: check the result when calling js function #17443

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Mar 20, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 20, 2019

@MarshallOfSound MarshallOfSound merged commit 821b88e into electron:5-0-x Mar 20, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 20, 2019

Release Notes Persisted

Fix crash when passing callbacks which return undefined to some APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.