Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'page-title-updated' event forwarding + documentation #18318

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented May 16, 2019

Backport of #18270

See that PR for details.

Notes: Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@trop trop bot referenced this pull request May 16, 2019

Merged

fix: 'page-title-updated' event forwarding + documentation #18270

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels May 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 16, 2019

@zcbenz

zcbenz approved these changes May 21, 2019

@zcbenz zcbenz merged commit 7ee06c3 into 5-0-x May 21, 2019

10 of 13 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
electron-arm-testing Build #20190516.7 had test failures
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190516.7 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 21, 2019

Release Notes Persisted

Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@zcbenz zcbenz deleted the trop/5-0-x-bp-fix-page-title-updated-event-forwarding-documentation-1557999211206 branch May 21, 2019

@AnalyzerTech

This comment has been minimized.

Copy link

commented Jun 18, 2019

(^__^))}{"HelloWorld"};
I did the unthinkable, and it was the biggest argument I have been in on line.
I sent a personal document to a site in a conversation that was in a navigating chat box.
I was not getting a response and I got concerned so like usual I inspect element and the argument takes
off in full effect. I began losing leverage and control over the argument so I left out of anger and in my return I see violation of using up space but I really needed to clear my head. after my break I eventually had to request IANA for help do to more than one force involved with the issue. If I leave a problem unsolved especially when it involves application and data management it gets serious. My 10 months of learning code has really shown me how to view the bigger picture of an event or a technical situation.
well, anyone who reads this message, remember their is always a way to overcome your mistakes and don't ever give up on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.