Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'page-title-updated' event forwarding + documentation #18319

Conversation

@trop
Copy link
Contributor

commented May 16, 2019

Backport of #18270

See that PR for details.

Notes: Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@trop trop bot referenced this pull request May 16, 2019

Merged

fix: 'page-title-updated' event forwarding + documentation #18270

5 of 5 tasks complete

@trop trop bot added 6-0-x backport labels May 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label May 16, 2019

@zcbenz

zcbenz approved these changes May 21, 2019

@zcbenz zcbenz merged commit a824e92 into 6-0-x May 21, 2019

13 of 14 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190516.5 succeeded
Details
electron-arm64-testing Build #20190516.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented May 21, 2019

Release Notes Persisted

Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@zcbenz zcbenz deleted the trop/6-0-x-bp-fix-page-title-updated-event-forwarding-documentation-1557999212824 branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.