Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix ffmpeg gn gen #19127

Merged
merged 2 commits into from
Jul 8, 2019
Merged

build: fix ffmpeg gn gen #19127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a86f8a3
revert #18993
Jul 5, 2019
62048eb
build: fix ffmpeg GN gen
Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions build/args/ffmpeg.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ is_component_ffmpeg = true
is_official_build = true
proprietary_codecs = false
ffmpeg_branding = "Chromium"
enable_dsyms = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, ideally we'd still generate symbols for this build, though i'm not sure we currently have a place to publish them.

seems like a good fix for now though 👍

... how come this didn't get caught by CI?

1 change: 0 additions & 1 deletion script/run-gn-format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def main():
for gn_file in sys.argv[1:]:
subprocess.check_call(
['gn', 'format', gn_file],
shell=True,
env=new_env
)

Expand Down