Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting capture mode and max file size in netLog API #19215

Merged
merged 6 commits into from Jul 25, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Jul 11, 2019

Description of Change

Adds two new options to netLog.startLogging: maxFileSize and captureMode.

NB. the names of the capture modes changed recently: https://chromium-review.googlesource.com/c/chromium/src/+/1685684. This PR uses the new names, and depends on that PR to fix the decoding of the "EVERYTHING" capture mode, which until that PR was decoded on the receiving mojo end as if it were the "INCLUDE_PRIVACY_INFO" capture mode.

Checklist

Release Notes

Notes: Added captureMode and maxFileSize options to the netLog API.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Jul 11, 2019
Copy link
Member

zcbenz left a comment

The test is failing in CI.

shell/browser/api/atom_api_net_log.cc Show resolved Hide resolved
shell/browser/api/atom_api_net_log.cc Show resolved Hide resolved
@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Jul 15, 2019

The test is failing in CI because of the reasoning stated in the PR description; this depends on a Chromium roll to be fixed.

@zcbenz
zcbenz approved these changes Jul 16, 2019
@nornagon nornagon force-pushed the netlog-opts branch 2 times, most recently from 3642e2d to 14c84f6 Jul 23, 2019
@nornagon nornagon force-pushed the netlog-opts branch from 14c84f6 to 5fa383c Jul 24, 2019
@nornagon nornagon merged commit 477661d into master Jul 25, 2019
12 of 13 checks passed
12 of 13 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190725.3 succeeded
Details
electron-arm64-testing Build #20190725.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Jul 25, 2019

Release Notes Persisted

Added captureMode and maxFileSize options to the netLog API.

@nornagon nornagon deleted the netlog-opts branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.