Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting capture mode and max file size in netLog API #19215

Merged
merged 6 commits into from Jul 25, 2019
Merged

feat: allow setting capture mode and max file size in netLog API #19215

merged 6 commits into from Jul 25, 2019

Conversation

nornagon
Copy link
Member

Description of Change

Adds two new options to netLog.startLogging: maxFileSize and captureMode.

NB. the names of the capture modes changed recently: https://chromium-review.googlesource.com/c/chromium/src/+/1685684. This PR uses the new names, and depends on that PR to fix the decoding of the "EVERYTHING" capture mode, which until that PR was decoded on the receiving mojo end as if it were the "INCLUDE_PRIVACY_INFO" capture mode.

Checklist

Release Notes

Notes: Added captureMode and maxFileSize options to the netLog API.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jul 11, 2019
zcbenz
zcbenz requested changes Jul 15, 2019
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing in CI.

shell/browser/api/atom_api_net_log.cc Show resolved Hide resolved
shell/browser/api/atom_api_net_log.cc Show resolved Hide resolved
@nornagon
Copy link
Member Author

The test is failing in CI because of the reasoning stated in the PR description; this depends on a Chromium roll to be fixed.

@nornagon nornagon force-pushed the netlog-opts branch 2 times, most recently from 3642e2d to 14c84f6 Compare July 24, 2019 23:00
@nornagon nornagon merged commit 477661d into master Jul 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 25, 2019

Release Notes Persisted

Added captureMode and maxFileSize options to the netLog API.

@nornagon nornagon deleted the netlog-opts branch July 25, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @zcbenz