Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add missing MenuItem roles #19329

Merged
merged 1 commit into from
Jul 31, 2019
Merged

docs: add missing MenuItem roles #19329

merged 1 commit into from
Jul 31, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Fixes #19321.

Adds missing MenuItem role typings. Also adds them to the smoke test to prevent future regressions.

cc @MarshallOfSound

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 18, 2019
@codebytere codebytere changed the title doc: add missing MenuItem roles docs: add missing MenuItem roles Jul 18, 2019
@codebytere codebytere force-pushed the fix-item-typings branch 4 times, most recently from 39399af to 39f4870 Compare July 18, 2019 23:56
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 19, 2019
felixrieseberg
felixrieseberg approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit a5f87ce into master Jul 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2019

No Release Notes

@codebytere codebytere deleted the fix-item-typings branch July 31, 2019 21:14
@trop
Copy link
Contributor

trop bot commented Jul 31, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Jul 31, 2019

I have automatically backported this PR to "7-0-x", please check out #19555

@trop trop bot mentioned this pull request Jul 31, 2019
Merged
codebytere added a commit that referenced this pull request Aug 1, 2019
@codebytere
doc: add missing MenuItem roles (#19329)
0d4f6f0
@codebytere codebytere mentioned this pull request Aug 1, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Aug 1, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19573

MarshallOfSound pushed a commit that referenced this pull request Aug 1, 2019
@codebytere @MarshallOfSound
doc: add missing MenuItem roles (#19329) (#19573)
7bec7e6
deepak1556 added a commit to microsoft/vscode that referenced this pull request Aug 8, 2019
@deepak1556
fix: update menu item role hideothers => hideOthers
2a67370 
electron/electron#19329
@kuychaco kuychaco mentioned this pull request Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrieseberg felixrieseberg felixrieseberg approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typings for MenuItemConstructorOptions.roles are missing possible values
2 participants
@codebytere @felixrieseberg