[WIP] chore: add console logs to test #20011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears Node's http.get() is getting stuck in some CI sessions when
run from inside a stream.readable.on('data') callback inside the mocha
test function. The cause of this blocking behavior isn't clear to me,
so this change is to explore whether using a promise-based fetch() call
affects anything.
The previous commit was green 100 out of 100 runs, so this seems to be ready for real consideration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Don't merge this.
This a tracer PR to learn more about how the remote-debugging-port test fails on Linux.
Checklist
npm testpassesRelease Notes
Notes: