Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove native_mate (Part 5) #20264

Merged
merged 5 commits into from Sep 19, 2019

Conversation

@zcbenz
Copy link
Member

commented Sep 17, 2019

Description of Change

Refs #16443.

This PR removes some uses of mate::ObjectTemplateBuilder, which is a major blocker to convert class methods to gin.

More uses will be removed in the next PR.

Release Notes

Notes: no-notes

@zcbenz zcbenz requested a review from deepak1556 Sep 17, 2019
@zcbenz zcbenz requested a review from electron/wg-upgrades as a code owner Sep 17, 2019
//
// It also uses gin_helper::CreateFunctionTemplate for function templates to
// support gin_helper types.
class ObjectTemplateBuilder {

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Sep 18, 2019

Member

Maybe as a follow up we can add this constructor to upstream gin, so that class can reused without duplicating ?

This comment has been minimized.

Copy link
@zcbenz

zcbenz Sep 19, 2019

Author Member

This class also relies on our fork of function_template.h so simply patching gin would not be enough, I'll add comment for it.

@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 18, 2019
@codebytere

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

@zcbenz this needs rebase then we should be g2g :)

@zcbenz zcbenz force-pushed the remove-native-mate-5 branch from 13cb769 to ff950c7 Sep 19, 2019
@codebytere codebytere merged commit 624ba4f into master Sep 19, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190919.5 succeeded
Details
electron-arm64-testing Build #20190919.5 succeeded
Details
electron-woa-testing Build #20190919.8 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 19, 2019

No Release Notes

@codebytere codebytere deleted the remove-native-mate-5 branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.