chore: remove native_mate (Part 5) #20264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Sep 18, 2019
| // | ||
| // It also uses gin_helper::CreateFunctionTemplate for function templates to | ||
| // support gin_helper types. | ||
| class ObjectTemplateBuilder { |
There was a problem hiding this comment.
Maybe as a follow up we can add this constructor to upstream gin, so that class can reused without duplicating ?
There was a problem hiding this comment.
This class also relies on our fork of function_template.h so simply patching gin would not be enough, I'll add comment for it.
deepak1556
approved these changes
Sep 18, 2019
jkleinsc
approved these changes
Sep 18, 2019
|
@zcbenz this needs rebase then we should be g2g :) |
zcbenz
force-pushed
the
remove-native-mate-5
branch
from
13cb769
to
ff950c7
Compare
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #16443.
This PR removes some uses of
mate::ObjectTemplateBuilder, which is a major blocker to convert class methods togin.More uses will be removed in the next PR.
Release Notes
Notes: no-notes