Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when exiting simple fullscreen on macOS #20282

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Sep 19, 2019

Backport of #20144.

See that PR for more details.

Notes: Fixed a crash when exiting simple fullscreen on macOS.

@codebytere codebytere requested a review from a team September 19, 2019 06:02
@codebytere codebytere changed the title fix: crash when exiting simple fullscreen on macOS (#20144) fix: crash when exiting simple fullscreen on macOS Sep 19, 2019
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new test is failing

@jkleinsc jkleinsc merged commit 15c89c8 into 6-0-x Sep 19, 2019
@release-clerk
Copy link

release-clerk bot commented Sep 19, 2019

Release Notes Persisted

Fixed a crash when exiting simple fullscreen on macOS.

@jkleinsc jkleinsc deleted the crash-simple-fs-6 branch September 19, 2019 18:29
@trop
Copy link
Contributor

trop bot commented Sep 19, 2019

I have automatically backported this PR to "5-0-x", please check out #20291

@sofianguy sofianguy added this to Fixed in 5.0.11 in 5.0.x Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
No open projects
5.0.x
Fixed in 5.0.11
Development

Successfully merging this pull request may close these issues.

None yet

2 participants