Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when exiting simple fullscreen on macOS #20282

Merged
merged 1 commit into from Sep 19, 2019

Conversation

@codebytere
Copy link
Member

commented Sep 19, 2019

Backport of #20144.

See that PR for more details.

Notes: Fixed a crash when exiting simple fullscreen on macOS.

@trop trop bot referenced this pull request Sep 19, 2019
6 of 6 tasks complete
@codebytere codebytere requested a review from electron/wg-releases Sep 19, 2019
@codebytere codebytere changed the title fix: crash when exiting simple fullscreen on macOS (#20144) fix: crash when exiting simple fullscreen on macOS Sep 19, 2019
Copy link
Contributor

left a comment

Looks like the new test is failing

@codebytere codebytere force-pushed the crash-simple-fs-6 branch from 47d68f2 to e15975a Sep 19, 2019
@codebytere codebytere requested a review from jkleinsc Sep 19, 2019
@jkleinsc jkleinsc merged commit 15c89c8 into 6-0-x Sep 19, 2019
17 checks passed
17 checks passed
Artifact Comparison No Changes
Details
Backportable? - 5-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190919.12 succeeded
Details
electron-arm64-testing Build #20190919.12 succeeded
Details
electron-woa-testing Build #20190919.12 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 19, 2019

Release Notes Persisted

Fixed a crash when exiting simple fullscreen on macOS.

@jkleinsc jkleinsc deleted the crash-simple-fs-6 branch Sep 19, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

I have automatically backported this PR to "5-0-x", please check out #20291

@sofianguy sofianguy added this to Fixed in 5.0.11 in 5.0.x Sep 24, 2019
@codebytere codebytere removed the merged/5-0-x label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5.0.x
Fixed in 5.0.11
2 participants
You can’t perform that action at this time.