Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update application-architecture.md #20370

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

chawk
Copy link
Contributor

@chawk chawk commented Sep 29, 2019

Updated the period to a comma. Appears to be a number typo.

Description of Change

Checklist

Release Notes

Notes: no-notes

Updated the period to a comma.   Appears to be a number typo.
@welcome
Copy link

welcome bot commented Sep 29, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Sep 29, 2019
@jkleinsc jkleinsc changed the title Update application-architecture.md docs Update application-architecture.md Sep 30, 2019
@jkleinsc jkleinsc changed the title docs Update application-architecture.md docs: Update application-architecture.md Sep 30, 2019
@jkleinsc
Copy link
Contributor

Thanks for the PR @chawk!

@jkleinsc
Copy link
Contributor

Merging as CI failures unrelated to doc change.

@jkleinsc jkleinsc merged commit 9457c79 into electron:master Sep 30, 2019
@welcome
Copy link

welcome bot commented Sep 30, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Sep 30, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants