Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fs.watch() behavior change in node >= 10.16.0 #20433

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix: fs.watch() behavior change in node >= 10.16.0 #20433

merged 1 commit into from
Oct 7, 2019

Conversation

deepak1556
Copy link
Member

Description of Change

Backports #20408

Checklist

Release Notes

Notes: fix fs.watch behavior change in node >=10.16.0

@deepak1556
fix: fs.watch() behavior change in node >= 10.16.0
ca4571e 
This reverts the patch from electron/node#100
which never got merged due to reasons outlined in libuv/libuv#2313

* Adds new patches that backports libuv/libuv#2459
  and libuv/libuv#2460

Based on nodejs/node#29460
@deepak1556 deepak1556 requested a review from a team October 4, 2019 22:21
@deepak1556 deepak1556 requested a review from a team as a code owner October 4, 2019 22:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 4, 2019
@trop trop bot mentioned this pull request Oct 4, 2019
Merged
6 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Oct 4, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 4, 2019
@deepak1556 deepak1556 merged commit 486a8ea into 5-0-x Oct 7, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 7, 2019

Release Notes Persisted

fix fs.watch behavior change in node >=10.16.0

@deepak1556 deepak1556 deleted the fix_libuv_fsevents-5.x branch October 7, 2019 20:06
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @codebytere