Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Map for callbacks in CallbacksRegistry #20565

Merged
merged 1 commit into from
Oct 15, 2019
Merged

refactor: use Map for callbacks in CallbacksRegistry #20565

merged 1 commit into from
Oct 15, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 14, 2019

Description of Change

Map has better semantics than plain object.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 14, 2019
@miniak miniak self-assigned this Oct 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 15, 2019
@codebytere codebytere merged commit 5273930 into master Oct 15, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 15, 2019

No Release Notes

@codebytere codebytere deleted the miniak/callbacks-registry-map branch October 15, 2019 16:14
@miniak miniak mentioned this pull request Oct 16, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @alexeykuzmin @codebytere