-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Secure Keyboard Entry APIs in macOS #20678
Merged
jkleinsc
merged 6 commits into
electron:master
from
mtgto:feat_darwin_secure_keyboard_entry
May 21, 2020
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
842cd03
feat: Add Secure Keyboard Entry APIs in macOS
mtgto a9bcdd3
fix: lint error in app.md for #20678
mtgto 8073ecc
fix: crash app.setSecureInputEnabled() in password textfield
mtgto 30f98fd
fix: export Secure keyboard Entry API to only macOS
mtgto 460f5a5
fix: lint error in browser_mac.mm for #20678
mtgto 619319f
test: add test for app.setSecureKeyboardEntryEnabled in macOS
mtgto File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
|
||
#include "shell/browser/browser.h" | ||
|
||
#include <memory> | ||
#include <string> | ||
#include <utility> | ||
|
||
|
@@ -430,4 +431,17 @@ void RemoveFromLoginItems() { | |
return true; | ||
} | ||
|
||
bool Browser::IsSecureKeyboardEntryEnabled() { | ||
return password_input_enabler_.get() != nullptr; | ||
} | ||
|
||
void Browser::SetSecureKeyboardEntryEnabled(bool enabled) { | ||
if (enabled) { | ||
password_input_enabler_ = | ||
std::make_unique<ui::ScopedPasswordInputEnabler>(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. initializer enable Secure Keyboard Entry. |
||
} else { | ||
password_input_enabler_.reset(); | ||
} | ||
} | ||
|
||
} // namespace electron |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling
setSecureInputEnabled()
with the same value twice should have no effect IMO.