fix: call InitializeContextRuntime in InitializeContext #20684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-context-initialize
branch
from
f449375
to
bed9dec
Compare
2 tasks
MarshallOfSound
approved these changes
Oct 23, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Node added the following commit in
v12.10.0that caused a crash in renderer process initialization becuase we don't directly callNewContext, and soInitializeContextwould not create primordials correctly and the following error would occur:node::Environment::CreateProperties(): Assertion `primordials->IsObject()' failed.cc @jkleinsc @ckerr @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Fixed a crash in Node.js initialization in renderer processes.