Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect size of windows on differently scaled monitors #21100

Merged
merged 2 commits into from Nov 15, 2019

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Nov 13, 2019

Description of Change

This reverts #19928 , we need the SetWindowPlacement hack for the scaling to work correctly and the problem this PR was trying to address #19423 can be fixed my not resetting the size of last_normal_placement_bounds_ a1562bd before adjusting the window placement as it had essentially null'd the right and bottom coordinates.

Fixes #20683
Fixes #20527

Checklist

Release Notes

Notes: fix incorrect size of windows on differently scaled monitors

@deepak1556 deepak1556 requested review from brenca, zcbenz and a team November 13, 2019 06:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 14, 2019
@trop
Copy link
Contributor

trop bot commented Nov 15, 2019

@deepak1556 has manually backported this PR to "6-1-x", please check out #21137

@trop
Copy link
Contributor

trop bot commented Nov 15, 2019

@deepak1556 has manually backported this PR to "7-1-x", please check out #21138

@trop
Copy link
Contributor

trop bot commented Nov 15, 2019

@deepak1556 has manually backported this PR to "8-x-y", please check out #21139

@deepak1556 deepak1556 merged commit fbc3bb8 into master Nov 15, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 15, 2019

Release Notes Persisted

fix incorrect size of windows on differently scaled monitors

@deepak1556 deepak1556 deleted the robo/fix_window_placement branch November 15, 2019 17:28
@deepak1556
Copy link
Member Author

deepak1556 commented Nov 15, 2019

The failing tests are unrelated to the PR. Seems to be caused by a recent change #20825 /cc @miniak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants