New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect size of windows on differently scaled monitors #21100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Nov 13, 2019
6 tasks
@deepak1556 has manually backported this PR to "6-1-x", please check out #21137 |
6 tasks
@deepak1556 has manually backported this PR to "7-1-x", please check out #21138 |
6 tasks
@deepak1556 has manually backported this PR to "8-x-y", please check out #21139 |
jkleinsc
approved these changes
Nov 15, 2019
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This reverts #19928 , we need the
SetWindowPlacement
hack for the scaling to work correctly and the problem this PR was trying to address #19423 can be fixed my not resetting the size oflast_normal_placement_bounds_
a1562bd before adjusting the window placement as it had essentially null'd the right and bottom coordinates.Fixes #20683
Fixes #20527
Checklist
npm test
passesRelease Notes
Notes: fix incorrect size of windows on differently scaled monitors