Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu should not be garbage-collected when popuping (7-1-x) #21225

Merged
merged 2 commits into from Nov 20, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Nov 20, 2019

Backport of #21169.

Notes: Fix context menu disappearing when showing.

@zcbenz zcbenz requested a review from miniak November 20, 2019 11:20
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2019
@trop trop bot added 7-1-x backport This is a backport PR labels Nov 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2019
@zcbenz zcbenz merged commit fbe36e2 into 7-1-x Nov 20, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 20, 2019

Release Notes Persisted

Fix context menu disappearing when showing.

@zcbenz zcbenz deleted the retain-menu-popup-7-1-x branch November 20, 2019 22:14
@momakes3
Copy link

momakes3 commented Nov 21, 2019

@zcbenz Thank you so much. Can we please have a release on 7.1.x channel with this? 6 and 8 have been released, only 7 doesn't include this 💜 Would really be awesome if we could have a new patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-1-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants