Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly plumb checkboxChecked on win #21312

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 27, 2019

Backport of #21248

See that PR for details.

Notes: Fixed an issue where the checkboxChecked value wasn't being updated in showMessageBox on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 27, 2019
@trop trop bot requested a review from codebytere November 27, 2019 18:37
@trop trop bot mentioned this pull request Nov 27, 2019
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 27, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 27, 2019
@zcbenz zcbenz merged commit 2bd83d0 into 8-x-y Nov 29, 2019
@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-correctly-plumb-checkboxchecked-on-win-1574879867089 branch November 29, 2019 08:23
@release-clerk
Copy link

release-clerk bot commented Nov 29, 2019

Release Notes Persisted

Fixed an issue where the checkboxChecked value wasn't being updated in showMessageBox on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants