Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hiding window menu should work on startup (7-1-x) #21449

Merged
merged 1 commit into from Dec 11, 2019

Conversation

@zcbenz
Copy link
Member

zcbenz commented Dec 10, 2019

Backport of #21436.

Notes: Fix window menu unable to hide on startup.

* fix: menu visibility should not be overwritten on startup

* fix: removing menu for window without global menubar

* test: setMenu tests are not for mac
@trop trop bot mentioned this pull request Dec 10, 2019
5 of 6 tasks complete
@trop trop bot added 7-1-x backport labels Dec 10, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 10, 2019
@zcbenz zcbenz merged commit 38c43ab into 7-1-x Dec 11, 2019
17 of 19 checks passed
17 of 19 checks passed
electron-woa-testing Build #20191210.4 had test failures
Details
electron-woa-testing #20191210.4 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191210.1 succeeded
Details
electron-arm-testing #20191210.1 succeeded
Details
electron-arm64-testing Build #20191210.1 succeeded
Details
electron-arm64-testing #20191210.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 11, 2019

Release Notes Persisted

Fix window menu unable to hide on startup.

@zcbenz zcbenz deleted the fix-default-menu-overwrite-7-1-x branch Dec 11, 2019
@kytwb kytwb mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.