Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid contextBridge crash when RenderFrame address is reused #21514

Conversation

@trop
Copy link
Contributor

trop bot commented Dec 13, 2019

Backport of #21501

See that PR for details.

Notes: Fixed contextBridge crash when opening and closing many windows.

loc and others added 2 commits Dec 13, 2019
Co-Authored-By: Jeremy Apthorp <nornagon@nornagon.net>
@trop trop bot requested a review from loc Dec 13, 2019
@trop trop bot added 7-1-x backport labels Dec 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Dec 13, 2019
@loc
loc approved these changes Dec 13, 2019
@MarshallOfSound MarshallOfSound merged commit 1e7f26e into 7-1-x Dec 13, 2019
11 of 17 checks passed
11 of 17 checks passed
build-linux Workflow: build-linux
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
electron-arm-testing in progress
Details
electron-arm64-testing in progress
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191213.31 succeeded
Details
electron-arm64-testing Build #20191213.30 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Dec 13, 2019

Release Notes Persisted

Fixed contextBridge crash when opening and closing many windows.

@MarshallOfSound MarshallOfSound deleted the trop/7-1-x-bp-fix-avoid-contextbridge-crash-when-renderframe-address-is-reused-1576260798730 branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.