fix: Windows checkboxChecked edge case #21852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #21831.
Most of the checkbox plumbing was fixed earlier, but one edge case remained; if you started with checkbox_checked
false
, and then checkedtrue
. This final bit:checkbox_checked ? verificationFlagChecked : false
led to the following logic flow:checkboxChecked: false
-> user leaved unchecked ->checkboxChecked === false
(correct ✅)checkboxChecked: true
-> user unchecks ->checkboxChecked === false
(correct ✅)checkboxChecked: false
-> user checks ->checkboxChecked === false
(incorrect 🔴 )checkboxChecked: true
-> user leaves checked ->checkboxChecked === true
(correct ✅)We shouldn't be gating the final return value on
checkbox_checked
; it only reflects the initial checked state. We simply need to returnverificationFlagChecked
, as it defaults to false anyway.cc @nornagon @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Fixed an edge case in checkbox logic on Windows.