Enable 'accept' attribute in 'input' label. #2200
Conversation
hokein
force-pushed
the
input_accept_attr
branch
from
5e309a9
to
04606a9
Compare
| @@ -56,10 +108,13 @@ void WebDialogHelper::RunFileChooser(content::WebContents* web_contents, | |||
| } | |||
|
|
|||
| std::vector<base::FilePath> paths; | |||
| auto browser_context = AtomBrowserMainParts::Get()->browser_context(); | |||
There was a problem hiding this comment.
We should use the browser_context of current WebContents.
There was a problem hiding this comment.
The current implementation relies on the PrefService in brightray::BrowserContext, which is aligned with Chromium's. And content::BrowserContext doesn't has such interface.
I know current implementation will cause <input> using the last used directory even in different WebContents, but this behavior is same with Chromium's(Chromium will share this last used directory to all WebContents in the same Profile).
There was a problem hiding this comment.
The current implementation relies on the PrefService in brightray::BrowserContext, which is aligned with Chromium's. And content::BrowserContext doesn't has such interface.
We can get it from current window.
I know current implementation will cause using the last used directory even in different WebContents, but this behavior is same with Chromium's(Chromium will share this last used directory to all WebContents in the same Profile).
Chrome's Profile is equivalent to Electron's Session, both of them inherit from content::BrowserContext.
There was a problem hiding this comment.
We can get it from current window.
I didn't find any APIs in NativeWindow. 😢
There was a problem hiding this comment.
NativeWindow is a WebContentsObserver so you can call web_contents().
There was a problem hiding this comment.
Actually all content::BrowserContext created in Electron should be an AtomBrowserContext, it is safe to call static_cast.
hokein
force-pushed
the
input_accept_attr
branch
from
6c12bfe
to
21e5054
Compare
|
👍 |
Enable 'accept' attribute in 'input' label.
Fixes #1768, #1780.