refactor: use NSVisualEffectMaterial* constants directly #22121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
use-contants-directly
branch
from
bb70d1f
to
63f810a
Compare
codebytere
commented
Feb 10, 2020
| @@ -1455,8 +1455,7 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { | |||
| relativeTo:nil]; | |||
| } | |||
|
|
|||
| std::string dep_warn = | |||
| " has been deprecated and will be removed in a future version of macOS."; | |||
| std::string dep_warn = " has been deprecated and removed as of macOS 10.15."; | |||
There was a problem hiding this comment.
Apple's docs indicate that all below deprecated APIs were removed in 10.15.
jkleinsc
requested changes
Feb 10, 2020
jkleinsc
approved these changes
Feb 10, 2020
deepak1556
approved these changes
Feb 10, 2020
|
No Release Notes |
|
/trop run backport-to 8-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "9-x-y", please check out #22148 |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
@codebytere has manually backported this PR to "8-x-y", please check out #22149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We wre previously static casting these because our minimum SDK was too low to directly use the constants, but now that we're on 10.15 we can use them directly, and so this PR updates them to do so.
cc @ckerr @jkleinsc @zcbenz
Checklist
npm testpassesRelease Notes
Notes: none