Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass safeDialogs preference to dialog properly #22353

Merged
merged 1 commit into from Feb 25, 2020
Merged

fix: pass safeDialogs preference to dialog properly #22353

merged 1 commit into from Feb 25, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #22350.

The safeDialog value was not being properly set in the MessageBoxSettings struct. This fixes that.

cc @zcbenz @ckerr

Checklist

Release Notes

Notes: Fixes an issue with safeDialog preferences not being passed properly.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 24, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 25, 2020
@codebytere codebytere merged commit c4f272e into master Feb 25, 2020
@codebytere codebytere deleted the fix-safe-dialogs branch February 25, 2020 16:48
@release-clerk
Copy link

release-clerk bot commented Feb 25, 2020

Release Notes Persisted

Fixes an issue with safeDialog preferences not being passed properly.

This was referenced Feb 25, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "7-1-x", please check out #22376

@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "8-x-y", please check out #22377

@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "8-x-y", please check out #22377

@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "7-1-x", please check out #22376

2 similar comments
@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "7-1-x", please check out #22376

@trop
Copy link
Contributor

trop bot commented Feb 25, 2020

I have automatically backported this PR to "7-1-x", please check out #22376

@ChALkeR ChALkeR mentioned this pull request Feb 26, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

safeDialogs option is broken since 7.0.0 (up to 9.0.0-beta.2, at least)
2 participants
@codebytere @zcbenz