Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upload sentry src bundles to symbol S3 bucket #22572

Merged
merged 1 commit into from Mar 9, 2020

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Mar 6, 2020

This uploads src.zip bundles compatible with Sentry's symbol service so that folks using Sentry automatically get inline source code in their crash stacks.

Docs for sentry's supported symbol servers are here https://getsentry.github.io/symbolicator/advanced/symbol-server-compatibility/

These will become available on Electron's symbol server

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner March 6, 2020 00:57
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 6, 2020
@MarshallOfSound MarshallOfSound changed the title [WIP] build: upload sentry src bundles to symbol S3 bucket build: upload sentry src bundles to symbol S3 bucket Mar 9, 2020
@MarshallOfSound MarshallOfSound merged commit 85d4040 into master Mar 9, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 9, 2020

No Release Notes

@trop
Copy link
Contributor

trop bot commented Mar 9, 2020

I have automatically backported this PR to "9-x-y", please check out #22617

@trop
Copy link
Contributor

trop bot commented Mar 9, 2020

I have automatically backported this PR to "7-1-x", please check out #22618

@trop
Copy link
Contributor

trop bot commented Mar 9, 2020

I have automatically backported this PR to "8-x-y", please check out #22619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants