Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: don't delete nightly tag after draft #22625

Merged
merged 1 commit into from Mar 10, 2020
Merged

chore: don't delete nightly tag after draft #22625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 4 additions & 9 deletions script/release/release-artifact-cleanup.js
View file
Open in desktop
Expand Up @@ -44,7 +44,6 @@ async function deleteDraft (releaseId, targetRepo) {
repo: targetRepo,
release_id: parseInt(releaseId, 10)
})
console.log(result)
if (!result.data.draft) {
console.log(`${fail} published releases cannot be deleted.`)
return false
Expand Down Expand Up @@ -85,15 +84,11 @@ async function cleanReleaseArtifacts () {

if (releaseId) {
if (isNightly) {
const deletedNightlyDraft = await deleteDraft(releaseId, 'nightlies')
await deleteDraft(releaseId, 'nightlies')

// don't delete tag unless draft deleted successfully
if (deletedNightlyDraft) {
await Promise.all([
deleteTag(args.tag, 'electron'),
deleteTag(args.tag, 'nightlies')
])
}
// We only need to delete the Electron tag since the
// nightly tag is only created at publish-time.
await deleteTag(args.tag, 'electron')
} else {
const deletedElectronDraft = await deleteDraft(releaseId, 'electron')
// don't delete tag unless draft deleted successfully
Expand Down