build: update eslint + eslint plugins

lib/browser/api/auto-updater/squirrel-update-win.js

@@ -93,7 +93,7 @@ exports.checkForUpdate = function (updateURL, callback) {
     try {
       // Last line of output is the JSON details about the releases
       const json = stdout.trim().split('\n').pop()
-      update = (ref = JSON.parse(json)) != null ? (ref1 = ref.releasesToApply) != null ? typeof ref1.pop === 'function' ? ref1.pop() : void 0 : void 0 : void 0
+      update = (ref = JSON.parse(json)) != null ? (ref1 = ref.releasesToApply) != null ? typeof ref1.pop === 'function' ? ref1.pop() : undefined : undefined : undefined
     } catch {
       // Disabled for backwards compatibility:
       // eslint-disable-next-line standard/no-callback-literal

lib/browser/api/menu-item-roles.js

@@ -254,28 +254,28 @@ const roles = {
 exports.roleList = roles
 
 const canExecuteRole = (role) => {
-  if (!roles.hasOwnProperty(role)) return false
+  if (!Object.prototype.hasOwnProperty.call(roles, role)) return false
   if (!isMac) return true
 
   // macOS handles all roles natively except for a few
   return roles[role].nonNativeMacOSRole
 }
 
 exports.getDefaultLabel = (role) => {
-  return roles.hasOwnProperty(role) ? roles[role].label : ''
+  return Object.prototype.hasOwnProperty.call(roles, role) ? roles[role].label : ''
 }
 
 exports.getDefaultAccelerator = (role) => {
-  if (roles.hasOwnProperty(role)) return roles[role].accelerator
+  if (Object.prototype.hasOwnProperty.call(roles, role)) return roles[role].accelerator
 }
 
 exports.shouldRegisterAccelerator = (role) => {
-  const hasRoleRegister = roles.hasOwnProperty(role) && roles[role].registerAccelerator !== undefined
+  const hasRoleRegister = Object.prototype.hasOwnProperty.call(roles, role) && roles[role].registerAccelerator !== undefined
   return hasRoleRegister ? roles[role].registerAccelerator : true
 }
 
 exports.getDefaultSubmenu = (role) => {
-  if (!roles.hasOwnProperty(role)) return
+  if (!Object.prototype.hasOwnProperty.call(roles, role)) return
 
   let { submenu } = roles[role]
 

lib/browser/api/menu.js

@@ -71,7 +71,7 @@ Menu.prototype.popup = function (options = {}) {
       window = wins[0]
     }
     if (!window) {
-      throw new Error(`Cannot open Menu without a TopLevelWindow present`)
+      throw new Error('Cannot open Menu without a TopLevelWindow present')
     }
   }
 
@@ -106,7 +106,7 @@ Menu.prototype.append = function (item) {
 }
 
 Menu.prototype.insert = function (pos, item) {
-  if ((item ? item.constructor : void 0) !== MenuItem) {
+  if ((item ? item.constructor : undefined) !== MenuItem) {
     throw new TypeError('Invalid item')
   }
 
@@ -194,8 +194,8 @@ function areValidTemplateItems (template) {
   return template.every(item =>
     item != null &&
     typeof item === 'object' &&
-    (item.hasOwnProperty('label') ||
-     item.hasOwnProperty('role') ||
+    (Object.prototype.hasOwnProperty.call(item, 'label') ||
+     Object.prototype.hasOwnProperty.call(item, 'role') ||
      item.type === 'separator'))
 }
 

lib/browser/api/net-log.js

@@ -11,7 +11,7 @@ Object.setPrototypeOf(module.exports, new Proxy({}, {
 
     const netLog = session.defaultSession.netLog
 
-    if (!Object.getPrototypeOf(netLog).hasOwnProperty(property)) return
+    if (!Object.prototype.hasOwnProperty.call(Object.getPrototypeOf(netLog), property)) return
 
     // check for properties on the prototype chain  that aren't functions
     if (typeof netLog[property] !== 'function') return netLog[property]

lib/browser/api/net.js

@@ -124,10 +124,12 @@ class SlurpStream extends Writable {
     super()
     this._data = Buffer.alloc(0)
   }
+
   _write (chunk, encoding, callback) {
     this._data = Buffer.concat([this._data, chunk])
     callback()
   }
+
   data () { return this._data }
 }
 
@@ -399,7 +401,7 @@ class ClientRequest extends Writable {
     this._urlLoader.on('redirect', (event, redirectInfo, headers) => {
       const { statusCode, newMethod, newUrl } = redirectInfo
       if (this._redirectPolicy === 'error') {
-        this._die(new Error(`Attempted to redirect, but redirect policy was 'error'`))
+        this._die(new Error('Attempted to redirect, but redirect policy was \'error\''))
       } else if (this._redirectPolicy === 'manual') {
         let _followRedirect = false
         this._followRedirectCb = () => { _followRedirect = true }

lib/browser/api/protocol.ts

@@ -9,7 +9,7 @@ Object.setPrototypeOf(protocol, new Proxy({}, {
     if (!app.isReady()) return
 
     const protocol = session.defaultSession!.protocol
-    if (!Object.getPrototypeOf(protocol).hasOwnProperty(property)) return
+    if (!Object.prototype.hasOwnProperty.call(Object.getPrototypeOf(protocol), property)) return
 
     // Returning a native function directly would throw error.
     return (...args: any[]) => (protocol[property as keyof Electron.Protocol] as Function)(...args)

lib/browser/api/touch-bar.js

@@ -103,7 +103,7 @@ class TouchBar extends EventEmitter {
     const { id } = window
 
     // Already added to window
-    if (this.windowListeners.hasOwnProperty(id)) return
+    if (Object.prototype.hasOwnProperty.call(this.windowListeners, id)) return
 
     window._touchBar = this
 

lib/browser/api/web-contents.js

@@ -263,8 +263,8 @@ WebContents.prototype.printToPDF = function (options) {
 
   if (options.pageRanges !== undefined) {
     const pageRanges = options.pageRanges
-    if (!pageRanges.hasOwnProperty('from') || !pageRanges.hasOwnProperty('to')) {
-      const error = new Error(`pageRanges must be an Object with 'from' and 'to' properties`)
+    if (!Object.prototype.hasOwnProperty.call(pageRanges, 'from') || !Object.prototype.hasOwnProperty.call(pageRanges, 'to')) {
+      const error = new Error('pageRanges must be an Object with \'from\' and \'to\' properties')
       return Promise.reject(error)
     }
 
@@ -333,7 +333,7 @@ WebContents.prototype.printToPDF = function (options) {
       return Promise.reject(error)
     }
   } else {
-    printSettings.mediaSize = PDFPageSizes['A4']
+    printSettings.mediaSize = PDFPageSizes.A4
   }
 
   // Chromium expects this in a 0-100 range number, not as float

lib/browser/message-port-main.ts

@@ -10,12 +10,15 @@ export class MessagePortMain extends EventEmitter {
       this.emit(channel, event)
     }
   }
+
   start () {
     return this._internalPort.start()
   }
+
   close () {
     return this._internalPort.close()
   }
+
   postMessage (...args: any[]) {
     if (Array.isArray(args[1])) {
       args[1] = args[1].map((o: any) => o instanceof MessagePortMain ? o._internalPort : o)

lib/browser/remote/server.ts

@@ -196,7 +196,7 @@ const throwRPCError = function (message: string) {
 
 const removeRemoteListenersAndLogWarning = (sender: any, callIntoRenderer: (...args: any[]) => void) => {
   const location = v8Util.getHiddenValue(callIntoRenderer, 'location')
-  let message = `Attempting to call a function in a renderer window that has been closed or released.` +
+  let message = 'Attempting to call a function in a renderer window that has been closed or released.' +
     `\nFunction provided here: ${location}`
 
   if (sender instanceof EventEmitter) {
@@ -281,11 +281,12 @@ const unwrapArgs = function (sender: electron.WebContents, frameId: number, cont
         }
         return ret
       }
-      case 'function-with-return-value':
+      case 'function-with-return-value': {
         const returnValue = metaToValue(meta.value)
         return function () {
           return returnValue
         }
+      }
       case 'function': {
         // Merge contextId and meta.id, since meta.id can be the same in
         // different webContents.

lib/common/reset-search-paths.ts

@@ -30,7 +30,7 @@ Object.defineProperty(electronModule, 'exports', {
   get: () => require('electron')
 })
 
-Module._cache['electron'] = electronModule
+Module._cache.electron = electronModule
 
 const originalResolveFilename = Module._resolveFilename
 Module._resolveFilename = function (request: string, parent: NodeModule, isMain: boolean) {

lib/content_script/init.js

@@ -15,7 +15,7 @@ v8Util.setHiddenValue(global, 'ipc-internal', v8Util.getHiddenValue(isolatedWorl
 // The process object created by webpack is not an event emitter, fix it so
 // the API is more compatible with non-sandboxed renderers.
 for (const prop of Object.keys(EventEmitter.prototype)) {
-  if (process.hasOwnProperty(prop)) {
+  if (Object.prototype.hasOwnProperty.call(process, prop)) {
     delete process[prop]
   }
 }

lib/renderer/api/remote.js

@@ -109,7 +109,7 @@ function setObjectMembers (ref, object, metaId, members) {
   if (!Array.isArray(members)) return
 
   for (const member of members) {
-    if (object.hasOwnProperty(member.name)) continue
+    if (Object.prototype.hasOwnProperty.call(object, member.name)) continue
 
     const descriptor = { enumerable: member.enumerable }
     if (member.type === 'method') {
@@ -188,7 +188,7 @@ function proxyFunctionProperties (remoteMemberFunction, metaId, name) {
       return true
     },
     get: (target, property, receiver) => {
-      if (!target.hasOwnProperty(property)) loadRemoteProperties()
+      if (!Object.prototype.hasOwnProperty.call(target, property)) loadRemoteProperties()
       const value = target[property]
       if (property === 'toString' && typeof value === 'function') {
         return value.bind(target)

lib/renderer/extensions/i18n.ts

@@ -45,7 +45,7 @@ const replacePlaceholders = (message: string, placeholders: Record<string, Place
 
 const getMessage = (extensionId: number, messageName: string, substitutions: string[]) => {
   const messages = getMessages(extensionId)
-  if (messages.hasOwnProperty(messageName)) {
+  if (Object.prototype.hasOwnProperty.call(messages, messageName)) {
     const { message, placeholders } = messages[messageName]
     return replacePlaceholders(message, placeholders, substitutions)
   }

lib/renderer/ipc-renderer-internal-utils.ts

@@ -14,7 +14,7 @@ export const handle = function <T extends IPCHandler> (channel: string, handler:
 }
 
 export function invokeSync<T> (command: string, ...args: any[]): T {
-  const [ error, result ] = ipcRendererInternal.sendSync(command, ...args)
+  const [error, result] = ipcRendererInternal.sendSync(command, ...args)
 
   if (error) {
     throw error

lib/renderer/security-warnings.ts

@@ -222,7 +222,7 @@ const warnAboutExperimentalFeatures = function (webPreferences?: Electron.WebPre
  */
 const warnAboutEnableBlinkFeatures = function (webPreferences?: Electron.WebPreferences) {
   if (!webPreferences ||
-    !webPreferences.hasOwnProperty('enableBlinkFeatures') ||
+    !Object.prototype.hasOwnProperty.call(webPreferences, 'enableBlinkFeatures') ||
     (webPreferences.enableBlinkFeatures && webPreferences.enableBlinkFeatures.length === 0)) {
     return
   }

lib/renderer/web-view/guest-view-internal.ts

@@ -24,10 +24,10 @@ const WEB_VIEW_EVENTS: Record<string, Array<string>> = {
   'did-frame-navigate': ['url', 'httpResponseCode', 'httpStatusText', 'isMainFrame', 'frameProcessId', 'frameRoutingId'],
   'did-navigate-in-page': ['url', 'isMainFrame', 'frameProcessId', 'frameRoutingId'],
   'focus-change': ['focus', 'guestInstanceId'],
-  'close': [],
-  'crashed': [],
+  close: [],
+  crashed: [],
   'plugin-crashed': ['name', 'version'],
-  'destroyed': [],
+  destroyed: [],
   'page-title-updated': ['title', 'explicitSet'],
   'page-favicon-updated': ['favicons'],
   'enter-html-full-screen': [],

lib/renderer/web-view/web-view-impl.ts

@@ -72,7 +72,7 @@ export class WebViewImpl {
     // heard back from createGuest yet. We will not reset the flag in this case so
     // that we don't end up allocating a second guest.
     if (this.guestInstanceId) {
-      this.guestInstanceId = void 0
+      this.guestInstanceId = undefined
     }
 
     this.beforeFirstNavigation = true
@@ -173,7 +173,7 @@ export class WebViewImpl {
     }
 
     for (const attributeName in this.attributes) {
-      if (this.attributes.hasOwnProperty(attributeName)) {
+      if (Object.prototype.hasOwnProperty.call(this.attributes, attributeName)) {
         params[attributeName] = this.attributes[attributeName].getValue()
       }
     }

lib/renderer/window-setup.ts

@@ -126,6 +126,7 @@ class BrowserWindowProxy {
   public get location (): LocationProxy | any {
     return this._location
   }
+
   public set location (url: string | any) {
     url = resolveURL(url, this.location.href)
     this._invokeWebContentsMethod('loadURL', url)

lib/sandboxed_renderer/init.js

@@ -20,7 +20,7 @@ v8Util.setHiddenValue(global, 'ipc-internal', new EventEmitter())
 // The process object created by webpack is not an event emitter, fix it so
 // the API is more compatible with non-sandboxed renderers.
 for (const prop of Object.keys(EventEmitter.prototype)) {
-  if (process.hasOwnProperty(prop)) {
+  if (Object.prototype.hasOwnProperty.call(process, prop)) {
     delete process[prop]
   }
 }

script/download-circleci-artifacts.js

@@ -38,7 +38,7 @@ async function downloadArtifact (name, buildNum, dest) {
     url: circleArtifactUrl,
     headers: {
       'Content-Type': 'application/json',
-      'Accept': 'application/json'
+      Accept: 'application/json'
     }
   }, true).catch(err => {
     if (args.verbose) {

script/gn-check.js

@@ -15,7 +15,7 @@ const DEPOT_TOOLS = path.resolve(SOURCE_ROOT, '..', 'third_party', 'depot_tools'
 
 const OUT_DIR = getOutDir({ outDir: args.outDir })
 if (!OUT_DIR) {
-  throw new Error(`No viable out dir: one of Debug, Testing, or Release must exist.`)
+  throw new Error('No viable out dir: one of Debug, Testing, or Release must exist.')
 }
 
 const env = Object.assign({

script/lint.js

@@ -57,7 +57,7 @@ function isObjCHeader (filename) {
   return /\/(mac|cocoa)\//.test(filename)
 }
 
-const LINTERS = [ {
+const LINTERS = [{
   key: 'c++',
   roots: ['shell'],
   test: filename => filename.endsWith('.cc') || (filename.endsWith('.h') && !isObjCHeader(filename)),
@@ -104,7 +104,7 @@ const LINTERS = [ {
   test: filename => filename.endsWith('.js') || filename.endsWith('.ts'),
   run: (opts, filenames) => {
     const cmd = path.join(SOURCE_ROOT, 'node_modules', '.bin', 'eslint')
-    const args = [ '--cache', '--ext', '.js,.ts', ...filenames ]
+    const args = ['--cache', '--ext', '.js,.ts', ...filenames]
     if (opts.fix) args.unshift('--fix')
     spawnAndCheckExitCode(cmd, args, { cwd: SOURCE_ROOT })
   }
@@ -202,7 +202,7 @@ const LINTERS = [ {
 function parseCommandLine () {
   let help
   const opts = minimist(process.argv.slice(2), {
-    boolean: [ 'c++', 'objc', 'javascript', 'python', 'gn', 'patches', 'help', 'changed', 'fix', 'verbose', 'only' ],
+    boolean: ['c++', 'objc', 'javascript', 'python', 'gn', 'patches', 'help', 'changed', 'fix', 'verbose', 'only'],
     alias: { 'c++': ['cc', 'cpp', 'cxx'], javascript: ['js', 'es'], python: 'py', changed: 'c', help: 'h', verbose: 'v' },
     unknown: arg => { help = true }
   })

script/release/ci-release-build.js

@@ -66,8 +66,8 @@ async function makeRequest (requestOptions, parseResponse) {
 async function circleCIcall (targetBranch, job, options) {
   console.log(`Triggering CircleCI to run build job: ${job} on branch: ${targetBranch} with release flag.`)
   const buildRequest = {
-    'branch': targetBranch,
-    'parameters': {
+    branch: targetBranch,
+    parameters: {
       'run-lint': false,
       'run-build-linux': false,
       'run-build-mac': false
@@ -185,7 +185,7 @@ async function circleCIRequest (url, method, requestBody) {
     url,
     headers: {
       'Content-Type': 'application/json',
-      'Accept': 'application/json'
+      Accept: 'application/json'
     },
     body: requestBody ? JSON.stringify(requestBody) : null
   }, true).catch(err => {

script/release/notes/index.js

@@ -144,8 +144,8 @@ async function getReleaseNotes (range, newVersion, explicitLinks) {
 
 async function main () {
   const opts = minimist(process.argv.slice(2), {
-    boolean: [ 'explicit-links', 'help' ],
-    string: [ 'version' ]
+    boolean: ['explicit-links', 'help'],
+    string: ['version']
   })
   opts.range = opts._.shift()
   if (opts.help || !opts.range) {