refactor: ginify Notification

[nornagon]

Description of Change

Also, add some tests.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR title follows semantic commit guidelines

Release Notes

Notes: none

[nornagon]

cc @sethlu

[zcbenz]

Can you add code to ensure the notification object is destroyed/cleared on exit?

It is a problem with Windows 10 that, if you don't clear the notification it would stay in the list even when it does not meant to.

[nornagon]

@zcbenz hmm, that seems like it might be the intended behavior on Windows in the underlying API?

If an app crashes, it won't be able to call any OS functions to remove notifications.

[zcbenz]

It think this is similar to Tray icons, it is fine to leave a ghost icon there if the process crashed, but it should clear the icon if it exited normally.

But anyway I tried to find out the original issue about this but didn't succeed, let's just leave it leaked on exit.

[zcbenz]

Also I think this should be marked as feat and documented for the same reason with #22822 (comment).

[nornagon]

NB this removes the .destroy method from Notification, because it's not documented and not tested.

[release-clerk]

No Release Notes