Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dialog fails to show after modal close #22889

Merged
merged 1 commit into from Mar 30, 2020
Merged

fix: dialog fails to show after modal close #22889

merged 1 commit into from Mar 30, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 30, 2020

Backport of #22858

See that PR for details.

Notes: Fixed an issue where native macOS dialogs sometimes failed to show after modal close.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 30, 2020
@trop trop bot requested a review from codebytere March 30, 2020 16:48
@trop trop bot mentioned this pull request Mar 30, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Mar 30, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 30, 2020
@jkleinsc jkleinsc merged commit d6ecc65 into 8-x-y Mar 30, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 30, 2020

Release Notes Persisted

Fixed an issue where native macOS dialogs sometimes failed to show after modal close.

@jkleinsc jkleinsc deleted the trop/8-x-y-bp-fix-dialog-fails-to-show-after-modal-close-1585586923298 branch March 30, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere