Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm codegen in script.runInNewContext #23129

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix: wasm codegen in script.runInNewContext #23129

merged 1 commit into from
Apr 17, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Fixes broken use of contextCodeGeneration parameter to Node.js' script.runInNewContext. Verified with broken Node.js smoke test which now works.

cc @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: Fixes broken use of contextCodeGeneration parameter to Node.js' script.runInNewContext().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 15, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 16, 2020
@codebytere codebytere merged commit 8b2e863 into master Apr 17, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 17, 2020

Release Notes Persisted

Fixes broken use of contextCodeGeneration parameter to Node.js' script.runInNewContext().

@codebytere codebytere deleted the enable-wasm-code-generation branch April 17, 2020 01:46
@trop
Copy link
Contributor

trop bot commented Apr 17, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Apr 17, 2020
@trop
Copy link
Contributor

trop bot commented Apr 17, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@codebytere codebytere mentioned this pull request Apr 17, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 17, 2020

@codebytere has manually backported this PR to "9-x-y", please check out #23146

@codebytere codebytere mentioned this pull request Apr 17, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 17, 2020

@codebytere has manually backported this PR to "8-x-y", please check out #23147

@trop trop bot added the merged/8-x-y label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound