Skip to content

fix: use Node's microtasks policy in node_main.cc #23154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 1 commit into from
Apr 21, 2020
Merged

fix: use Node's microtasks policy in node_main.cc #23154

codebytere merged 1 commit into from
Apr 21, 2020

Conversation

@ckerr
Copy link
Member

@ckerr ckerr commented Apr 17, 2020 •
edited by codebytere
Loading

Description of Change

Backport of #23153.

Manually backport #23153 because node::IsolateSettings hadn't been created yet in this version of Node.js. This manual backport hardcodes kExplicit instead of getting the policy setting from node::IsolateSettings.

CC @codebytere

Checklist

Release Notes

Notes: Fixed Promise timeout issue when running Electron as Node.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 17, 2020
@trop trop bot mentioned this pull request Apr 17, 2020
Merged
5 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 17, 2020
@codebytere codebytere merged commit 74d391b into 9-x-y Apr 21, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 21, 2020

Release Notes Persisted

Fixed Promise timeout issue when running Electron as Node.

@codebytere codebytere deleted the use-nodes-microtask-policy_9-x-y branch April 21, 2020 20:43
@trop
Copy link
Contributor

trop bot commented Apr 21, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/7-2-x label Apr 21, 2020
@trop
Copy link
Contributor

trop bot commented Apr 21, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@ckerr ckerr mentioned this pull request Apr 22, 2020
Merged
5 tasks
@trop trop bot added the merged/8-x-y label Apr 23, 2020
ckerr added a commit that referenced this pull request Apr 28, 2020
@ckerr
fix: use Node's microtasks policy in node_main.cc (#23154)
d262592 
Fixes #21515.
codebytere pushed a commit that referenced this pull request Apr 29, 2020
@ckerr
fix: use Node's microtasks policy in node_main.cc (#23154) (#23324)
69683de 
Fixes #21515.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@nornagon nornagon nornagon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

9-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ckerr @nornagon @codebytere