Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Node's microtasks policy in node_main.cc #23154

Merged
merged 1 commit into from Apr 21, 2020

Conversation

@ckerr
Copy link
Member

@ckerr ckerr commented Apr 17, 2020

Description of Change

Backport of #23153.

Manually backport #23153 because node::IsolateSettings hadn't been created yet in this version of Node.js. This manual backport hardcodes kExplicit instead of getting the policy setting from node::IsolateSettings.

CC @codebytere

Checklist

Release Notes

Notes: Fixed Promise timeout issue when running Electron as Node.

@codebytere codebytere merged commit 74d391b into 9-x-y Apr 21, 2020
18 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Apr 21, 2020

Release Notes Persisted

Fixed Promise timeout issue when running Electron as Node.

@codebytere codebytere deleted the use-nodes-microtask-policy_9-x-y branch Apr 21, 2020
@trop
Copy link
Contributor

@trop trop bot commented Apr 21, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/7-2-x label Apr 21, 2020
@trop
Copy link
Contributor

@trop trop bot commented Apr 21, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants