test: fix type errors in devToolsWebContents #23187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
the
fast-track 🚅
codebytere
changed the title
codebytere
force-pushed
the
devtoolswc-prop
branch
from
47e5655
to
bbc7245
Compare
MarshallOfSound
approved these changes
Apr 20, 2020
nornagon
approved these changes
Apr 20, 2020
deepak1556
approved these changes
Apr 20, 2020
|
Failing tests are unrelated, merging |
|
No Release Notes |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I have automatically backported this PR to "9-x-y", please check out #23189 |
|
@codebytere has manually backported this PR to "8-x-y", please check out #23206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes type errors in
api-web-contents-spec.ts. We can assert thatdevToolsWebContentsis notnullsafely whenw.webContents.openDevTools()has been invoked.cc @nornagon
Notes: none