fix: prevent Menu.buildFromTemplate with empty array

[codebytere]

Description of Change

Closes #23282.

Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.

cc @zcbenz @jkleinsc @MarshallOfSound

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant documentation is changed or added
• PR title follows semantic commit guidelines
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a potential crash when menu is created from an empty template.

[zcbenz]

Would the crash in original issue still happen when calling win.setMenu(new Menu)?

[dezsiszabi]

Just to give a usecase.

We have a wrapper package around electron window creation/menu creation. It exposes a WindowBuilder, TrayBuilder, MenuBuilder etc (using a fluent API/builder pattern to compose the electron application).

In this wrapper code we called a code similar to

window.setMenu(Menu.buildFromTemplate(this.menuBuilders.map(mb => mb.build())));

Of course the issue should be prevented in our code by adding defensive checks and not call setMenu when there are no menu builders.

That said, I'd still prefer an early failure which doesn't result in a crash. (I mean a crash shouldn't ever happen no matter how insanely the JavaScript API was (ab)used.)

Either:

1. Fail early by throwing an exception if Menu.buildFromTemplate is called with an empty array
   OR
2. Menu.buildFromTemplate should return null if called with an empty array.

In both cases the documentation should mention the behavior when Menu.buildFromTemplate is called with an empty array.

[codebytere]

@zcbenz it shouldn't from my read of this function, but i could be wrong!

[release-clerk]

Release Notes Persisted

Fixed a potential crash when menu is created from an empty template.

[trop]

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "9-x-y", please check out #23351

[trop]

@codebytere has manually backported this PR to "8-x-y", please check out #23353

[trop]

@codebytere has manually backported this PR to "7-2-x", please check out #23354

[codebytere]

New information came to light about how this may break existing codepaths - i'm going to open a new PR that avoids this breakage and backport that.