docs: event.newGuest for new-window in WebContents and webContents in BrowsweWindow's constructor #23355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
According to the example codes in the documentation of `new-window` event in `WebContents`, `webContents` in `BrowsweWindow` constructor options and `newGuest` in `event` argument of `new-window` handler are both existing but documented. This patch is for adding the related documentations. Also, it provides typescript-definitations for these two properties.
6 tasks
MarshallOfSound
approved these changes
Apr 30, 2020
|
No Release Notes |
codebytere
deleted the
trop/8-x-y-bp-docs-event-newguest-for-new-window-in-webcontents-and-webcontents-in-browswewindow-s-constructor-1588263934677
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21698
See that PR for details.
Notes:
newGuestinnew-windowevent ofWebContentsandwebContentsinBrowsweWindowconstructor were well-documented.