fix: multiple extension filters on macOS #23409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-multiple-extensions
branch
from
27c2c17
to
f70af1c
Compare
codebytere
force-pushed
the
fix-multiple-extensions
branch
from
f70af1c
to
9c9b36b
Compare
ckerr
approved these changes
May 7, 2020
|
Release Notes Persisted
|
This was referenced May 7, 2020
|
I have automatically backported this PR to "8-x-y", please check out #23449 |
|
I have automatically backported this PR to "9-x-y", please check out #23450 |
|
I have automatically backported this PR to "7-2-x", please check out #23451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #23316.
Fixes an issue whereby
macOSwould fail to allow file extensions containing periods.macOS, it turns out, is incapable of understanding multiple file extensions, so if something liketar.gzis passed in it will not match files correctly because it natively will throw out anything it doesn't recognize as a valid system extension. We fix this by tokenizing the extension and only passing the final component of the extension (as delimited by.) tomacOS.Tested with https://gist.github.com/7ce9ea238a838bdfb30337ac43daa8a6.
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue whereby
macOSwould fail to allow file extensions containing periods.