test: fix conditions for some tests #23489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykuzmin
changed the title
alexeykuzmin
force-pushed
the
alkuzmin/fix-conditional-tests
branch
7 times, most recently
from
ac1cec6
to
5b12aeb
Compare
deepak1556
approved these changes
May 10, 2020
alexeykuzmin
force-pushed
the
alkuzmin/fix-conditional-tests
branch
from
5b12aeb
to
5ada2fc
Compare
zcbenz
approved these changes
May 11, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "9-x-y" cleanly; |
alexeykuzmin
added a commit
that referenced
this pull request
May 11, 2020
(cherry picked from commit dc3de49)
|
@alexeykuzmin has manually backported this PR to "9-x-y", please check out #23494 |
|
/trop run backport |
|
The backport process for this PR has been manually initiated, here we go! :D |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
@alexeykuzmin has manually backported this PR to "8-x-y", please check out #23607 |
zcbenz
pushed a commit
that referenced
this pull request
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix conditions for a few tests.
Checklist
npm testpassesRelease Notes
Notes: none