Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use correct v8_context_snapshot_generator in mksnapshot zip #23539

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 12, 2020

Backport of #23536

See that PR for details.

Notes: Fixes v8_context_snapshot_generator included in arm/arm64 mksnapshot zip files.

@trop trop bot requested a review from jkleinsc May 12, 2020 18:53
@trop trop bot added 7-2-x backport This is a backport PR labels May 12, 2020
@jkleinsc
Copy link
Contributor

Merging as CI failures unrelated to PR change.

@jkleinsc jkleinsc merged commit 66b407e into 7-2-x May 13, 2020
@release-clerk
Copy link

release-clerk bot commented May 13, 2020

Release Notes Persisted

Fixes v8_context_snapshot_generator included in arm/arm64 mksnapshot zip files.

@jkleinsc jkleinsc deleted the trop/7-2-x-bp-build-use-correct-v8_context_snapshot_generator-in-mksnapshot-zip-1589309600493 branch May 13, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant