chore: look harder for a commit's pull request. #23593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR numbers are almost always listed parenthetically in the commit message; but when something is committed manually, it could be missing. This change uses octokit's listPullRequestsAssociatedWithCommit() as a second approach to finding a commit's PR. Last night's Releases WG meeting noted that "re-enable pdf viewer" was missing from the notes. This PR fixes that omission.
ckerr
changed the title
|
Results of this change in the generated 9.0.0 notes: --- baseline.md 2020-05-13 19:23:23.817365248 -0500
+++ test.md 2020-05-14 13:42:43.384661705 -0500
@@ -14,6 +14,7 @@
* Added support for property access to some getter/setter pairs on `BrowserWindow`. [#23208](https://github.com/electron/electron/pull/23208)
* Added support for the chrome.extension.getBackgroundPage API when building with enable_electron_extensions. [#22177](https://github.com/electron/electron/pull/22177)
* Allow an optional callback parameter for WebFrame.executeJavaScript* methods, which is called synchronously unless the target context is paused. [#22501](https://github.com/electron/electron/pull/22501)
+ * Restored support for pdfium-based PDF viewer. [#22131](https://github.com/electron/electron/pull/22131)
## Fixes
|
codebytere
approved these changes
May 14, 2020
|
No Release Notes |
|
I have automatically backported this PR to "9-x-y", please check out #23596 |
MarshallOfSound
added a commit
that referenced
this pull request
May 21, 2020
This reverts commit 2342aaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
PR numbers are almost always listed parenthetically in the commit message; but when something is committed manually, it could be missing due to human error. This PR adds octokit's
listPullRequestsAssociatedWithCommit()as a second approach to finding a commit's PR.Last night's Releases WG meeting discovered that "re-enable pdf viewer" was missing from the draft release notes for 9.0.0. This PR fixes that omission.
CC @electron/wg-releases
Checklist
npm testpassesRelease Notes
Notes: none