Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow unsandboxed renderers to request new privileges (5-0-x) #23881

Closed
wants to merge 2 commits into from
Closed

fix: allow unsandboxed renderers to request new privileges (5-0-x) #23881

wants to merge 2 commits into from

Conversation

the-j0k3r
Copy link

@the-j0k3r the-j0k3r commented Jun 1, 2020

Description of Change

Backport of #19953

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
  • PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

If this fails test please help if you can.

@the-j0k3r the-j0k3r requested a review from a team as a code owner June 1, 2020 16:07
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2020
@welcome
Copy link

welcome bot commented Jun 1, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@trop trop bot added 5-0-x backport This is a backport PR labels Jun 1, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2020
@the-j0k3r
Copy link
Author

I dont think theres anything I can do to fix the errors, and if there is Ive no idea what =)

@nornagon
Copy link
Member

nornagon commented Jun 1, 2020

The 5.x release line is no longer supported.

@nornagon nornagon closed this Jun 1, 2020
@yacc143
Copy link

yacc143 commented Jul 13, 2020

The 5.x release line is no longer supported.

So why does Atom, which is not exactly a trivial or irrelevant Electron app, still use 5.x?

I'm currently wondering if it's worth my time to code up a crude work around (think LD_PRELOAD, fiddling with prctl, thus potentially making my Atom a little bit less safe), or if the issue that make the Atom Terminal Tab a bit useless (all snap installed binaries are symlinks to /usr/bin/snap, a suid root binary, and Ubuntu is delivering more and more stuff via snaps nowadays).

E.g. on my laptop the aws "binary" is a link /usr/bin/snap. Does not work in my editor terminal tab. My working environment setup scripts using fabric internally call sudo, oops. And so on.

@the-j0k3r
Copy link
Author

@yacc143

See atom/atom#20764 (comment)

Eventually Atom will ship a version of electron thats supported, until then thats the official explanation

@the-j0k3r the-j0k3r mentioned this pull request Jul 16, 2020
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants