Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compensate for lazy-loaded circular deps #23955

Merged
merged 1 commit into from Jun 8, 2020
Merged

fix: compensate for lazy-loaded circular deps #23955

merged 1 commit into from Jun 8, 2020

Conversation

codebytere
Copy link
Member

Backport of #23890

See that PR for details.

Notes: Fixed an issue where rmdir and rmdirSync work with original-fs in an asar context.

@codebytere codebytere requested a review from a team June 3, 2020 18:21
@codebytere codebytere requested a review from a team as a code owner June 3, 2020 18:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@trop trop bot mentioned this pull request Jun 3, 2020
Merged
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jun 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 3, 2020
@codebytere codebytere force-pushed the circular-fs-8 branch 3 times, most recently from d42b547 to 78908a8 Compare June 4, 2020 00:22
@codebytere codebytere merged commit a061706 into 8-x-y Jun 8, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 8, 2020

Release Notes Persisted

Fixed an issue where rmdir and rmdirSync work with original-fs in an asar context.

@codebytere codebytere deleted the circular-fs-8 branch June 8, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @jkleinsc