docs: fix explanation of darwin auto-quit prevention #24003

ghost · 2020-06-06T23:58:05Z

Description of Change

I fixed the comment above the auto-quit prevention for macOS.
Before it suggested the code quits the app, now it says the code prevents the app from quitting.

Release Notes

Notes: none

malept

The comments should be consolidated.

malept · 2020-06-07T17:40:20Z

docs/tutorial/first-app.md

@@ -141,7 +141,7 @@ function createWindow () {
 // Some APIs can only be used after this event occurs.
 app.whenReady().then(createWindow)

-// Quit when all windows are closed.
+// Prevent app from auto-quitting on macOS.


Suggested change

// Prevent app from auto-quitting on macOS.

// Quit when all windows are closed, except on macOS. There, it's common

// for applications and their menu bar to stay active until the user quits

// explicitly with Cmd + Q.

malept · 2020-06-07T17:43:32Z

docs/tutorial/first-app.md

  // On macOS it is common for applications and their menu bar
  // to stay active until the user quits explicitly with Cmd + Q


Suggested change

// On macOS it is common for applications and their menu bar

// to stay active until the user quits explicitly with Cmd + Q

erickzhao · 2020-06-08T17:34:47Z

Thank you for the contribution! Follow-up: after this gets merged, it would be best to update our templates in quick-start and Fiddle for consistency:

malept · 2020-06-08T19:03:45Z

Follow-up: after this gets merged, it would be best to update our templates in quick-start and Fiddle for consistency

Also Electron Forge:

welcome · 2020-06-11T02:08:29Z

Congrats on merging your first pull request! 🎉🎉🎉

release-clerk · 2020-06-11T02:08:34Z

No Release Notes

…tart' (#38) 1. updated dev dependencies 2. Content-Security-Policy added f844bb7 : Ref - electron/electron-quick-start@0ed07b8 & electron/electron-quick-start#334 3. no need to hold on to mainWindow reference 478f1be : Ref -electron/electron#21957 & electron/electron-quick-start#357 4. don't listen to 'activate' until ready 3e5cfff : fixes electron/electron#23476 & Ref: electron/electron-quick-start#382 5. fix explanation of darwin auto-quit prevention 7679354 : Ref : electron/electron#24003 & electron/electron-quick-start#394 6. docs: update stale comment - renderer has no access to Node 8e4701c : Ref: electron/electron-quick-start@6788309 & electron/electron-quick-start#308

initial commit: ported over electron-quick-start to use typescript change name to electron-quick-start-typescript upgrade to electron 1.8 Fixed addres of project Update package-lock.json name has changed from `electron-quick-start-ts` to `electron-quick-start-typescript` Update js references to ts upgrade electron version to latest ⚡️ fix link Added documentation for npm run watch Added script for running build in watch mode upgrade to more recent version of electro Update Electron and TypeScript to last versions Type in title Just fixed typscript to typescript chore: upgrade dependencies refactor: use preload script instead of nodeIntegration in the renderer process updates to sync with the latest version of 'electron/electron-quick-start' (#38) 1. updated dev dependencies 2. Content-Security-Policy added electron/electron-quick-start-typescript@f844bb7 : Ref - electron/electron-quick-start@0ed07b8 & electron/electron-quick-start#334 3. no need to hold on to mainWindow reference electron/electron-quick-start-typescript@478f1be : Ref -electron/electron#21957 & electron/electron-quick-start#357 4. don't listen to 'activate' until ready electron/electron-quick-start-typescript@3e5cfff : fixes electron/electron#23476 & Ref: electron/electron-quick-start#382 5. fix explanation of darwin auto-quit prevention electron/electron-quick-start-typescript@7679354 : Ref : electron/electron#24003 & electron/electron-quick-start#394 6. docs: update stale comment - renderer has no access to Node electron/electron-quick-start-typescript@8e4701c : Ref: electron/electron-quick-start@6788309 & electron/electron-quick-start#308 build(deps): bump lodash from 4.17.15 to 4.17.19 (#41) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps-dev): bump electron from 9.0.4 to 9.3.0 Bumps [electron](https://github.com/electron/electron) from 9.0.4 to 9.3.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.0.4...v9.3.0) Signed-off-by: dependabot[bot] <support@github.com> chore: Migrate from TSLint to ESLint (#40) Co-authored-by: Vlad Neacsu <vlad.neacsu@optilyz.com> build(deps-dev): bump electron from 9.3.0 to 9.3.1 (#45) Bumps [electron](https://github.com/electron/electron) from 9.3.0 to 9.3.1. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.3.0...v9.3.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs: update README with link to TypeScript Co-authored-by: Igor Matyushkin <hello.wizman@gmail.com> build(deps): bump ini from 1.3.5 to 1.3.7 (#48) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.7) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps-dev): bump electron from 9.3.1 to 9.4.0 Bumps [electron](https://github.com/electron/electron) from 9.3.1 to 9.4.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/master/docs/breaking-changes.md) - [Commits](electron/electron@v9.3.1...v9.4.0) Signed-off-by: dependabot[bot] <support@github.com> build(deps): bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> chore: add dependabot config file For parity with electron-quick-start. build(deps-dev): bump eslint from 7.3.1 to 7.27.0 Bumps [eslint](https://github.com/eslint/eslint) from 7.3.1 to 7.27.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.3.1...v7.27.0) Signed-off-by: dependabot[bot] <support@github.com> Imports electron/electron-quick-start-typescript

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 6, 2020

ghost mentioned this pull request Jun 6, 2020

docs: fix darwin auto-quit template #23960

Closed

vhashimotoo requested a review from a team June 7, 2020 00:49

vhashimotoo added the documentation 📓 label Jun 7, 2020

malept suggested changes Jun 7, 2020

View reviewed changes

docs: fix explanation of darwin auto-quit prevention

3d14fcf

ghost requested a review from malept June 7, 2020 18:54

malept approved these changes Jun 7, 2020

View reviewed changes

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 8, 2020

erickzhao approved these changes Jun 8, 2020

View reviewed changes

zcbenz approved these changes Jun 11, 2020

View reviewed changes

zcbenz merged commit a33c10c into electron:master Jun 11, 2020

vazra mentioned this pull request Jun 15, 2020

updates to sync with the latest version of 'electron/electron-quick-start' electron/electron-quick-start-typescript#38

Merged

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020

docs: fix explanation of darwin auto-quit prevention (electron#24003)

8a4d8da

sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021

docs: fix explanation of darwin auto-quit prevention (electron#24003)

a6ebd0e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: fix explanation of darwin auto-quit prevention #24003

docs: fix explanation of darwin auto-quit prevention #24003

ghost commented Jun 6, 2020

malept left a comment

malept Jun 7, 2020

malept Jun 7, 2020

erickzhao commented Jun 8, 2020 •

edited

malept commented Jun 8, 2020

welcome bot commented Jun 11, 2020

release-clerk bot commented Jun 11, 2020

-// Prevent app from auto-quitting on macOS.
+// Quit when all windows are closed, except on macOS. There, it's common
+// for applications and their menu bar to stay active until the user quits
+// explicitly with Cmd + Q.

		// On macOS it is common for applications and their menu bar
		// to stay active until the user quits explicitly with Cmd + Q

docs: fix explanation of darwin auto-quit prevention #24003

docs: fix explanation of darwin auto-quit prevention #24003

Conversation

ghost commented Jun 6, 2020

Description of Change

Release Notes

malept left a comment

Choose a reason for hiding this comment

malept Jun 7, 2020

Choose a reason for hiding this comment

malept Jun 7, 2020

Choose a reason for hiding this comment

erickzhao commented Jun 8, 2020 • edited

malept commented Jun 8, 2020

welcome bot commented Jun 11, 2020

release-clerk bot commented Jun 11, 2020

erickzhao commented Jun 8, 2020 •

edited