Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use RenderViewReady to call InstallTransparency #24390

Merged
merged 1 commit into from Jul 6, 2020
Merged

fix: use RenderViewReady to call InstallTransparency #24390

merged 1 commit into from Jul 6, 2020

Conversation

adill
Copy link
Contributor

@adill adill commented Jul 1, 2020

Description of Change

This fixes #24384. I encountered the same crash and fixed it in my fork but hadn't attempted to upstream it yet.

Checklist

Release Notes

Notes: fix crash when opening offscreen transparent windows with gpu acceleration off

@adill
fix: use RenderViewReady to call InstallTransparency
d56bc24 
this fixes a crash with transparent OSR when GPU acceleration is
disabled
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 1, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 2, 2020
@MarshallOfSound MarshallOfSound merged commit cf74ee3 into electron:master Jul 6, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 6, 2020

Release Notes Persisted

fix crash when opening offscreen transparent windows with gpu acceleration off

@adill adill deleted the fix-transparent-osr-crash branch July 13, 2020 17:35
sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@adill @sentialx
fix: use RenderViewReady to call InstallTransparency (electron#24390)
434f30e 
this fixes a crash with transparent OSR when GPU acceleration is
disabled
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@adill @sentialx
fix: use RenderViewReady to call InstallTransparency (electron#24390)
53e16c4 
this fixes a crash with transparent OSR when GPU acceleration is
disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offscreen transparent window cause app crashing
4 participants
@adill @nornagon @codebytere @MarshallOfSound